🔧 Improve health check robustness and timing

🕐 Enhanced Timing:
- Increase attempts from 12 to 15
- Increase wait time from 10 to 15 seconds between attempts
- Add longer curl timeouts (10s max, 5s connect)

🔍 Better Debugging:
- More verbose health check logging
- Show container status on each failed attempt
- Clearer success/failure messages
- Track attempt progress (X/15)

🌐 Improved Curl Options:
- --max-time 10: Overall timeout
- --connect-timeout 5: Connection timeout
- -s: Silent mode (less noise)
- -f: Fail on HTTP errors

🎯 Addresses Race Condition:
- Container shows as healthy but curl fails immediately
- Longer waits allow application full startup
- Better visibility into what's happening during checks

✅ Should resolve timing issues with container startup

.gitea/workflows/release.yml

@@ -3,16 +3,16 @@ name: Release - Northern Thailand Ping River Monitor
 on:
   push:
     tags:
-      - 'v*.*.*'
+      - "v*.*.*"
   workflow_dispatch:
     inputs:
       version:
-        description: 'Release version (e.g., v3.1.3)'
+        description: "Release version (e.g., v3.1.3)"
         required: true
         type: string
 
 env:
-  PYTHON_VERSION: '3.11'
+  PYTHON_VERSION: "3.11"
   REGISTRY: git.b4l.co.th
   IMAGE_NAME: b4l/northern-thailand-ping-river-monitor
   # GitHub token for better rate limits and authentication
@@ -71,7 +71,7 @@ jobs:
     needs: create-release
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11', '3.12']
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
 
     steps:
       - name: Checkout code
@@ -161,8 +161,6 @@ jobs:
         with:
           token: ${{ secrets.GITEA_TOKEN}}
 
-
-
   # Test release deployment locally
   deploy-release:
     name: Test Release Deployment
@@ -178,6 +176,13 @@ jobs:
         with:
           token: ${{ secrets.GITEA_TOKEN }}
 
+      - name: Log in to Container Registry
+        uses: docker/login-action@v3
+        with:
+          registry: ${{ env.REGISTRY }}
+          username: ${{ vars.WORKER_USERNAME}}
+          password: ${{ secrets.CI_BOT_TOKEN }}
+
       - name: Deploy to production (Local Test)
         run: |
           echo "🚀 Testing ${{ needs.create-release.outputs.version }} deployment locally..."
@@ -206,23 +211,37 @@ jobs:
 
           echo "🔍 Running health checks against local container..."
 
-        # Wait for the application to be ready
-        for i in {1..12}; do
-          if curl -f http://localhost:8080/health; then
-            echo "✅ Health endpoint responding"
+          # Check if container is running
+          docker ps | grep ping-river-monitor-test || echo "⚠️ Container not found in docker ps"
+
+          # Check container logs for any startup issues
+          echo "📋 Recent container logs:"
+          docker logs --tail 10 ping-river-monitor-test || true
+
+          # Wait for the application to be ready with more robust checking
+          echo "🔍 Testing application readiness..."
+          for i in {1..15}; do
+            echo "⏳ Attempt $i/15: Testing health endpoint..."
+            
+            # Use curl with more verbose output and longer timeout
+            if curl -f -s --max-time 10 --connect-timeout 5 http://127.0.0.1:8080/health; then
+              echo "✅ Health endpoint responding successfully!"
               break
             else
-            echo "⏳ Waiting for health endpoint... (attempt $i/12)"
-            sleep 10
+              echo "❌ Health check failed, waiting 15 seconds..."
+              # Show what's happening with the container
+              echo "Container status:"
+              docker ps | grep ping-river-monitor-test || echo "Container not found"
+              sleep 15
             fi
           done
 
           # Test API endpoints
           echo "🧪 Testing API endpoints..."
-        curl -f http://localhost:8080/health || exit 1
-        curl -f http://localhost:8080/docs || exit 1
-        curl -f http://localhost:8080/stations || exit 1
-        curl -f http://localhost:8080/metrics || exit 1
+          curl -f http://127.0.0.1:8080/health || exit 1
+          curl -f http://127.0.0.1:8080/docs || exit 1
+          curl -f http://127.0.0.1:8080/stations || exit 1
+          curl -f http://127.0.0.1:8080/metrics || exit 1
 
           echo "✅ All health checks passed!"
 
@@ -242,8 +261,6 @@ jobs:
           echo "Status: Container tested successfully"
           echo "Ready for production deployment"
 
-
-
   # Notify stakeholders
   notify:
     name: Notify Release

Dockerfile

@@ -22,26 +22,27 @@ FROM python:3.11-slim
 # Set working directory
 WORKDIR /app
 
-# Install runtime dependencies
+# Install runtime dependencies and create user
 RUN apt-get update && apt-get install -y \
     wget \
     curl \
     && rm -rf /var/lib/apt/lists/* \
-    && groupadd -r appuser && useradd -r -g appuser appuser
+    && groupadd -r appuser && useradd -r -g appuser appuser \
+    && mkdir -p /home/appuser/.local
 
 # Copy Python packages from builder stage
-COPY --from=builder /root/.local /root/.local
+COPY --from=builder /root/.local /home/appuser/.local
 
 # Copy application code
 COPY . .
 
 # Create logs directory and set permissions
-RUN mkdir -p logs && chown -R appuser:appuser /app
+RUN mkdir -p logs && chown -R appuser:appuser /app /home/appuser/.local
 
 # Set environment variables
 ENV PYTHONUNBUFFERED=1
 ENV TZ=Asia/Bangkok
-ENV PATH=/root/.local/bin:$PATH
+ENV PATH=/home/appuser/.local/bin:$PATH
 
 # Switch to non-root user
 USER appuser