🔧 Make health checks more robust with detailed debugging

🔍 Enhanced Debugging:
- Show HTTP response codes and response bodies
- Remove -f flag that was causing curl to fail on valid responses
- Add detailed logging for each endpoint test
- Show container logs on failures

🌐 Improved Health Check Logic:
- Check HTTP code = 200 AND response body exists
- Use curl -w to capture HTTP status codes
- Parse response and status separately
- More tolerant of response format variations

🧪 Better API Endpoint Testing:
- Test each endpoint individually with status reporting
- Show specific HTTP codes for each endpoint
- Clear success/failure messages per endpoint
- Exit only on actual HTTP errors

🎯 Addresses CI-Specific Issues:
- Local testing shows endpoints work correctly
- CI environment may have different curl behavior
- More detailed output will help identify root cause
- Removes false failures from -f flag sensitivity

 Should resolve curl failures despite HTTP 200 responses

.gitea/workflows/release.yml

@@ -3,16 +3,16 @@ name: Release - Northern Thailand Ping River Monitor
 on:
   push:
     tags:
-      - 'v*.*.*'
+      - "v*.*.*"
   workflow_dispatch:
     inputs:
       version:
-        description: 'Release version (e.g., v3.1.3)'
+        description: "Release version (e.g., v3.1.3)"
         required: true
         type: string
 
 env:
-  PYTHON_VERSION: '3.11'
+  PYTHON_VERSION: "3.11"
   REGISTRY: git.b4l.co.th
   IMAGE_NAME: b4l/northern-thailand-ping-river-monitor
   # GitHub token for better rate limits and authentication
@@ -71,7 +71,7 @@ jobs:
     needs: create-release
     strategy:
       matrix:
-        python-version: ['3.9', '3.10', '3.11', '3.12']
+        python-version: ["3.9", "3.10", "3.11", "3.12"]
 
     steps:
       - name: Checkout code
@@ -161,8 +161,6 @@ jobs:
         with:
           token: ${{ secrets.GITEA_TOKEN}}
 
-
-
   # Test release deployment locally
   deploy-release:
     name: Test Release Deployment
@@ -213,23 +211,60 @@ jobs:
 
           echo "🔍 Running health checks against local container..."
 
-        # Wait for the application to be ready
+          # Check if container is running
-        for i in {1..12}; do
+          docker ps | grep ping-river-monitor-test || echo "⚠️ Container not found in docker ps"
-          if curl -f http://localhost:8080/health; then
+
-            echo "✅ Health endpoint responding"
+          # Check container logs for any startup issues
+          echo "📋 Recent container logs:"
+          docker logs --tail 10 ping-river-monitor-test || true
+
+          # Wait for the application to be ready with more robust checking
+          echo "🔍 Testing application readiness..."
+          for i in {1..15}; do
+            echo "⏳ Attempt $i/15: Testing health endpoint..."
+            
+            # Test health endpoint with detailed debugging
+            echo "Testing health endpoint..."
+            
+            # First try with verbose output to see what's happening
+            response=$(curl -s --max-time 10 --connect-timeout 5 -w "HTTP_CODE:%{http_code}" http://127.0.0.1:8080/health)
+            http_code=$(echo "$response" | grep -o "HTTP_CODE:[0-9]*" | cut -d: -f2)
+            response_body=$(echo "$response" | sed 's/HTTP_CODE:[0-9]*$//')
+            
+            echo "HTTP Code: $http_code"
+            echo "Response Body: $response_body"
+            
+            if [ "$http_code" = "200" ] && [ -n "$response_body" ]; then
+              echo "✅ Health endpoint responding successfully!"
               break
             else
-            echo "⏳ Waiting for health endpoint... (attempt $i/12)"
+              echo "❌ Health check failed (HTTP: $http_code), waiting 15 seconds..."
-            sleep 10
+              # Show what's happening with the container
+              echo "Container status:"
+              docker ps | grep ping-river-monitor-test || echo "Container not found"
+              echo "Recent container logs:"
+              docker logs --tail 5 ping-river-monitor-test || true
+              sleep 15
             fi
           done
 
-        # Test API endpoints
+          # Test API endpoints with better error handling
           echo "🧪 Testing API endpoints..."
-        curl -f http://localhost:8080/health || exit 1
+          
-        curl -f http://localhost:8080/docs || exit 1
+          endpoints=("health" "docs" "stations" "metrics")
-        curl -f http://localhost:8080/stations || exit 1
+          for endpoint in "${endpoints[@]}"; do
-        curl -f http://localhost:8080/metrics || exit 1
+            echo "Testing /$endpoint..."
+            response=$(curl -s --max-time 10 -w "HTTP_CODE:%{http_code}" http://127.0.0.1:8080/$endpoint)
+            http_code=$(echo "$response" | grep -o "HTTP_CODE:[0-9]*" | cut -d: -f2)
+            
+            if [ "$http_code" = "200" ]; then
+              echo "✅ /$endpoint: OK (HTTP $http_code)"
+            else
+              echo "❌ /$endpoint: FAILED (HTTP $http_code)"
+              echo "Response: $(echo "$response" | sed 's/HTTP_CODE:[0-9]*$//')"
+              exit 1
+            fi
+          done
 
           echo "✅ All health checks passed!"
 
@@ -249,8 +284,6 @@ jobs:
           echo "Status: Container tested successfully"
           echo "Ready for production deployment"
 
-
-
   # Notify stakeholders
   notify:
     name: Notify Release